Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta,ddl: fix duplicate entry error when insert after drop and recover table (#52761) #53185

Merged
merged 3 commits into from
Nov 7, 2024
Merged

meta,ddl: fix duplicate entry error when insert after drop and recover table (#52761) #53185

merged 3 commits into from
Nov 7, 2024

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #52761

What problem does this PR solve?

Issue Number: close #52680

Problem Summary:

What changed and how does it work?

After #39041, CreateTableAndSetAutoID do not set the auto id correctly.
We should recover RowID, AutoIncrementID, RandomID..

P.S. drop table do not remove auto id entry in autoid service, this is not a problem.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Follow the steps described in the issue.

  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@tiancaiamao @ti-chi-bot
This is an automated cherry-pick of pingcap#52761
3cd3b6a 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels May 11, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request May 11, 2024
Merged
13 tasks
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 11, 2024
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 3, 2024
@codecov Codecov
Copy link

codecov bot commented Jun 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-7.1@a3c139d). Learn more about missing BASE report.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-7.1     #53185   +/-   ##
================================================
  Coverage               ?   75.3086%           
================================================
  Files                  ?       1212           
  Lines                  ?     398614           
  Branches               ?          0           
================================================
  Hits                   ?     300191           
  Misses                 ?      80691           
  Partials               ?      17732

@tiancaiamao
Copy link
Contributor

PTAL @bb7133 @tangenta @D3Hunter

@tiancaiamao
Copy link
Contributor

PTAL @bb7133 @D3Hunter @tangenta

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Oct 28, 2024
@tiancaiamao tiancaiamao requested review from lance6716 and CbcWestwolf and removed request for lance6716 November 6, 2024 06:41
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 6, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 6, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 6, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-06 06:49:06.980422321 +0000 UTC m=+1023659.819577868: ☑️ agreed by tangenta.
  • 2024-11-06 07:15:27.685859499 +0000 UTC m=+1025240.525015045: ☑️ agreed by lance6716.

@tiancaiamao
Copy link
Contributor

/test unit-test

@tiprow tiprow
Copy link

tiprow bot commented Nov 7, 2024

@tiancaiamao: No presubmit jobs available for pingcap/tidb@release-7.1

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit 0c8eb42 into pingcap:release-7.1 Nov 7, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta approved these changes

@lance6716 lance6716 lance6716 approved these changes

@CbcWestwolf CbcWestwolf Awaiting requested review from CbcWestwolf

Assignees

@tiancaiamao tiancaiamao

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-chi-bot @tiancaiamao @lance6716 @tangenta